[Linux-ha-dev] Do we need ccdv?

[Dejan Muhamedagic]

Hi,

On Tue, Feb 26, 2008 at 11:39:22AM +0900, DAIKI MATSUDA wrote:
> Hi, all.
> 
> I am trying the latest development source code on RHEL 5 and
> encoutered the following error,
> gmake[1]: Entering directory
> `/home/matsuda/redhat/BUILD/Heartbeat-Dev-527d1843faeb/tools'
> if gcc -DHAVE_CONFIG_H -I. -I. -I../include -I../include -I../include
> -I../include -I../linux-ha -I../linux-ha -I.
> ./libltdl -I../libltdl  -D_BSD_SOURCE -D__BSD_SOURCE -D__FAVOR_BSD
> -DHAVE_NET_ETHERNET_H  -I/usr/include/glib-2.0
> -I/usr/lib/glib-2.0/include   -I/usr/include/libxml2  -O2 -g -pipe
> -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fst
> ack-protector --param=ssp-buffer-size=4 -m32 -march=i386
> -mtune=generic -fasynchronous-unwind-tables -fno-unit-at-
> a-time  -Wall -Wmissing-prototypes -Wmissing-declarations
> -Wstrict-prototypes -Wdeclaration-after-statement -Wpoin
> ter-arith -Wwrite-strings -Wcast-qual -Wcast-align -Wbad-function-cast
> -Winline -Wmissing-format-attribute -Wforma
> t=2 -Wformat-security -Wformat-nonliteral -Wno-long-long
> -Wno-strict-aliasing -Werror  -ggdb3 -funsigned-char -MT
> cl_status.o -MD -MP -MF ".deps/cl_status.Tpo" -c -o cl_status.o cl_status.c; \
>         then mv -f ".deps/cl_status.Tpo" ".deps/cl_status.Po"; else rm
> -f ".deps/cl_status.Tpo"; exit 1; fi
> gcc  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
> -fstack-protector --param=ssp-buffer-size=4 -m32 -mar
> ch=i386 -mtune=generic -fasynchronous-unwind-tables
> -fno-unit-at-a-time  -Wall -Wmissing-prototypes -Wmissing-decl
> arations -Wstrict-prototypes -Wdeclaration-after-statement
> -Wpointer-arith -Wwrite-strings -Wcast-qual -Wcast-alig
> n -Wbad-function-cast -Winline -Wmissing-format-attribute -Wformat=2
> -Wformat-security -Wformat-nonliteral -Wno-lo
> ng-long -Wno-strict-aliasing -Werror  -ggdb3 -funsigned-char -o ccdv
> ../tools/ccdv.c
> cc1: warnings being treated as errors
> ../tools/ccdv.c: In function 'main':
> ../tools/ccdv.c:362: warning: ignoring return value of 'write',
> declared with attribute warn_unused_result
> gmake[1]: *** [ccdv] Error 1
> gmake[1]: Leaving directory
> `/home/matsuda/redhat/BUILD/Heartbeat-Dev-527d1843faeb/tools'
> make: *** [all-recursive] Error 1
> error: Bad exit status from /var/tmp/rpm-tmp.50842 (%build)
> 
> So, I applied the attached the patch.
> 
> But ccdv is not installed the system. And I removed the part from
> Makefile and there is no error. So, do we need ccdv?

Don't know. ccdv is apparently a tool to help with reading
compiler output. I've never used it. For whatever reason
cl_status depends on it. Perhaps in order to build it?

Thanks for the patch, I'll apply it.

Cheers,

Dejan

> 
> Regards
> MATSUDA, Daiki

> --- Heartbeat-Dev-c8d573589311/tools/ccdv.c.orig	2008-02-12 17:19:22.000000000 +0900
> +++ Heartbeat-Dev-c8d573589311/tools/ccdv.c	2008-02-13 15:06:52.000000000 +0900
> @@ -358,8 +358,10 @@
>  panic:
>  	gDumpCmdArgs = 1;	/* print cmd when there are errors */
>  	DumpFormattedOutput();
> -	while ((nread = read(fd, emerg, (size_t) sizeof(emerg))) > 0)
> -		(void) write(2, emerg, (size_t) nread);
> +	while ((nread = read(fd, emerg, (size_t) sizeof(emerg))) > 0) {
> +		ssize_t retval;
> +		retval = write(2, emerg, (size_t) nread);
> +	}
>  	Wait();
>  	exit(gExitStatus);
>  }	/* main */

> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/