[Linux-ha-dev] ipmilan.c in CVS tree may be broken

[DAIKI MATSUDA]

Hi, Heartbeat Develepers all.

I found the broken file in CVS Dev tree source code. It is
lib/plugin/stonith/ipmilan.c and I paste the diff.
By comparing with 2.1.2 source, ipmilan_set_config has been changed
and may be bug.

Best Regards
MATSUDA, Daiki

[matsuda at jojo stonith]$ diff -uNrp ipmilan.c.orig ipmilan.c
--- ipmilan.c.orig      2007-11-20 09:21:04.000000000 +0900
+++ ipmilan.c   2007-11-20 09:43:29.000000000 +0900
@@ -435,10 +435,9 @@ ipmilan_set_config(StonithPlugin* s, Sto
                LOG(PIL_CRIT, "ipmilan priv value is NULL.  See "
                "README.ipmilan for allowed values");
                return S_OOPS;
-       if (strcmp(namestocopy[4].s_value, "operator") == 0) {
+       } else if (strcmp(namestocopy[4].s_value, "operator") == 0) {
                tmp->privilege = 3;
-               }
-       if (strcmp(namestocopy[4].s_value, "admin") == 0) {
+       } else if (strcmp(namestocopy[4].s_value, "admin") == 0) {
                tmp->privilege = 4;
        } else {
                LOG(PIL_CRIT, "ipmilan priv value '%s' invalid.  See "