[Linux-ha-dev] c6eee6c1911e (test -L /proc/$$/exe)

[Lars Marowsky-Bree]

On 2007-05-30T18:00:21, David Lee <t.d.lee at durham.ac.uk> wrote:

> Lars: The recent update c6eee6c1911e risks non-portability.  The main
> issue is that the '-L' flag in "test -L" is not available in the Bourne
> shell on some operating systems (one example is Solaris 8), causing syntax
> errors.

OK. My hope was that it might cause an error or failed test, but that
doesn't matter - it only needs to work on platforms where it _is_
supported afterall ;-)

> I believe that '-h' has exactly the same meaning ("exists and is a
> symbolic link").  More importantly, I believe that '-h' is available more
> widely.  (As a Venn diagram in OS space, I think that '-h' is a superset
> of '-L'.)
> 
> Could you consider adjusting this '-L' to '-h', please?  (And perhaps a
> comment?)

Sure. My man page also says is -L and -h are equivalent, and doesn't
mention portability issues. I've switched it to -h.

> (Are there any OSes likely to be used for heartbeat which don't have '-h'
> at all?)

I don't think so.


Regards,
    Lars

-- 
Teamlead Kernel, SuSE Labs, Research and Development
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde