[Linux-ha-dev] Fwd: Re: Bug#420206: heartbeat-2: Bashism in IPAddr2

[Simon Horman]

On Tue, May 01, 2007 at 09:14:37AM +0100, David Lee wrote:
> On Tue, 1 May 2007, Simon Horman wrote:
> 
> > Here is my take on a fix for this problem.
> >
> > --
> > Horms
> >   H: http://www.vergenet.net/~horms/
> >   W: http://www.valinux.co.jp/en/
> >
> > Subject: Remove bashim from IPaddr
> > From: Simon Horman <horms at verge.net.au>
> >
> > Use sed instead of cut + bashism to calculate a MAC if one isn't provided.
> >
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> >
> > diff -r 75fa88f5e100 resources/OCF/IPaddr2.in
> > --- a/resources/OCF/IPaddr2.in	Tue May 01 12:41:29 2007 +0900
> > +++ b/resources/OCF/IPaddr2.in	Tue May 01 13:07:49 2007 +0900
> > @@ -348,16 +348,19 @@ ip_init() {
> > [...]
> 
> Just a quick additional check... I'm not an Hg expert.  But at some point
> (a222241cd70d ?) the opening line was changed from "#!/bin/sh" to
> "#!/bin/bash". Will your patch ensure that this is undone, so that we are
> completely back in the pure Bourne world?

Thanks for reminding me about that, I had forgotten. I will make sure
it is/goes back to /bin/sh

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/