[Linux-ha-dev] IPaddr2 gives a spurious warning on stop

[Thomas Guyot-Sionnest]

> -----Original Message-----
> From: linux-ha-dev-bounces at lists.linux-ha.org 
> [mailto:linux-ha-dev-bounces at lists.linux-ha.org] On Behalf Of 
> Lars Marowsky-Bree
> Sent: March 5, 2007 5:02
> To: High-Availability Linux Development List
> Subject: Re: [Linux-ha-dev] IPaddr2 gives a spurious warning on stop
> 
> On 2007-03-05T17:25:44, Aníbal Monsalve Salazar 
> <anibal at sgi.com> wrote:
> 
> > I created the following patch to fix this bug.
> > 
> > --- resources/OCF/IPaddr2.in~	2007-01-12 
> 13:57:08.000000000 +1100
> > +++ resources/OCF/IPaddr2.in	2007-03-05 
> 16:29:41.797530093 +1100
> > @@ -380,7 +380,7 @@
> >  	ipaddr="$1"
> >  	iface="$2"
> >  
> > -	CMD="$IP2UTIL -f inet addr delete $ipaddr dev $iface"
> > +	CMD="$IP2UTIL -f inet addr delete $ipaddr/32 dev $iface"
> >  
> >  	ocf_log info "$CMD"
> >  	$CMD
> 
> No, it should not.
> 
> The IP might have been added with a different netmask. We 
> want it to be
> deleted regardless of the netmask.
> 
> The warning from ip should be ignored.
> 
> Alternatively, one should look up the netmask prior to deletion.

Hey, wait!! The netmask is usually passed from command-line. Why not just
force it? Removal should use the same netmask and there'll be no problem
this way.

I.e. on my setup I run something like: IPaddr2::1.2.3.4/24/eth0

IMHO omiting the netmask is a bad thing. It will create a /32 ip and a /32
cannot commmunicate with anything (though it might work if ppl create a 2nd
address on the same net...)

Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3076 bytes
Desc: not available
Url : http://lists.community.tummy.com/pipermail/linux-ha-dev/attachments/20070305/8ca5abb3/smime.bin