[Linux-ha-dev] Re: Solved! Re: [Linux-HA] Tieing DRBD into heartbeat

[Andrew Beekhof]

On 6/28/07, David Lee <t.d.lee at durham.ac.uk> wrote:
> On Thu, 28 Jun 2007, Andrew Beekhof wrote:
>
> > [...]
> > A bunch of the directories locations are.
> > But instead of using the variables defined there, all the RAs redefine
> > (for example)
> >   HA_VARRUN=@localstatedir@/run/
> > possibly with a different name.
>
> Could you clarify a little?  I thought much of this was already in place.
> But perhaps we're talking about subtly different things.
>
> Some time ago, lots of source files, particularly in "resources/OCF" used
> to do that sort of "HA_VARRUN=@localstatedir@/run/" redefinition business.
> The multiplicity of such repeated things seemed most undesirable, with
> much danger of divergence and inconsistency
>
> So a few months ago, I committed some patches which abstracted that out
> into "configure".  That now establishes, just once, a set of common
> directory names "HA_VARRUNDIR", "HA_VARRUNHBDIR", "HA_VARRUNHBRSCDIR" and
> so on (and similarly for "/etc"-like things).

ok, my patch must have pre-dated your cleanup, so it looks like things
are better now.
however there are still examples of the same thing occurring with
other variables. eg:

AudibleAlarm.in:PIDFILE=@HA_VARRUNDIR@/heartbeat-bell
WinPopup.in:WINPOPUPFILE=@HA_VARRUNDIR@/WinPopup
Xinetd.in:HA_VARRUNDIR=@HA_VARRUNDIR@
apache.in:HA_VARRUNDIR=@HA_VARRUNDIR@


and that doesn't address the other issue of using autoconf to find the
full path to binaries like fsck.

>
> So the RAs ought to be using (and I think now mostly do) those new
> references to directory names, now consistently established by configure.
>
> There may well be scope for further abstraction into a common "." file.
>
> Some other redefinitions also lurk in several "Makefile.in".  A quick grep
> reveals "havarrundir" and "havarlibdir" (and similar) things in several of
> them.  It would be good to see those removed altogether, as the equivalent
> information ought now to present, and now consistently so, in "config.h".

I thought i caught all those... seems i need a second go.

> > > I think it's only included for the
> > > logging stuff.
> > >
> > > I think that's also something which ought to be cleaned up.
> > >
> > > David, Matthew, any takers? ;-)
> >
> > I'll do it, i have a patch i've been kicking around for a few months
> > that just needs some polish
>
> Thanks, Andrew!
>
> For me, heartbeat has to be an almost completely spare-time activity to
> fitted in around work (heartbeat is not an official part of the day-job),
> family, and the rest of life.
>
> Best wishes.
>
>
> --
>
> :  David Lee                                I.T. Service          :
> :  Senior Systems Programmer                Computer Centre       :
> :  UNIX Team Leader                         Durham University     :
> :                                           South Road            :
> :  http://www.dur.ac.uk/t.d.lee/            Durham DH1 3LE        :
> :  Phone: +44 191 334 2752                  U.K.                  :
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>