[Linux-ha-dev] [PATCH] [BUILD] don't ignore errors on install

[Simon Horman]

It seems to me that when creating directories on install
the only error that can be safely ignored is chown. Or more
to the point, its the only one that may fail under normal circumstances.

Also, I believe that mkdir -p will not producec errors if
the directory already exists, so there is no need to check for
its existance.

Signed-off-by: Simon Horman <horms at verge.net.au>

Index: heartbeat/Makefile.am
===================================================================
--- heartbeat.orig/Makefile.am	2007-07-28 13:23:01.000000000 +0900
+++ heartbeat/Makefile.am	2007-07-28 13:23:10.000000000 +0900
@@ -96,18 +96,18 @@ deb:		dist
 		rm -rf $(distdir)
 
 install-exec-local:
-	-test -p $(DESTDIR)$(coredir) || mkdir -p $(DESTDIR)$(coredir)
+	test -p $(DESTDIR)$(coredir) || mkdir -p $(DESTDIR)$(coredir)
 	-chown root $(DESTDIR)$(coredir)
-	-chmod 755 $(DESTDIR)$(coredir)
-	-test -p $(DESTDIR)$(coredir)/root || mkdir -p $(DESTDIR)$(coredir)/root
+	chmod 755 $(DESTDIR)$(coredir)
+	mkdir -p $(DESTDIR)$(coredir)/root
 	-chown root $(DESTDIR)$(coredir)/root
-	-chmod 700 $(DESTDIR)$(coredir)/root
-	-test -p $(DESTDIR)$(coredir)/nobody || mkdir -p $(DESTDIR)$(coredir)/nobody
+	chmod 700 $(DESTDIR)$(coredir)/root
+	mkdir -p $(DESTDIR)$(coredir)/nobody
 	-chown nobody $(DESTDIR)$(coredir)/nobody
-	-chmod 700 $(DESTDIR)$(coredir)/nobody
-	-test -p $(DESTDIR)$(coredir)/$(hauser) || mkdir -p $(DESTDIR)$(coredir)/$(hauser)
+	chmod 700 $(DESTDIR)$(coredir)/nobody
+	mkdir -p $(DESTDIR)$(coredir)/$(hauser)
 	-chown $(hauser) $(DESTDIR)$(coredir)/$(hauser)
-	-chmod 700 $(DESTDIR)$(coredir)/$(hauser)
+	chmod 700 $(DESTDIR)$(coredir)/$(hauser)
 	cd $(DESTDIR)@HA_LIBHBDIR@;				\
 	for file in `ls $(DESTDIR)$(HBSHAREDIR)`;			\
 	do if [  -d $$file ]; then continue; fi;	\