[Linux-ha-dev] gcc: an observation

[Lars Ellenberg]

/ 2007-02-16 16:00:03 +0000
\ David Lee:
> This is really just an observation, not (necessarily) a request for
> fixing a problem.  (Although if someone could say "yes, that's trivially
> fixable by doing XYZ", that would be nice.)
> 
> Some of our systems share an old gcc compiler, version 2.95.2, on which
> heartbeat has always built successfully until recently.  At some point in
> the last six months or so, something has changed to stop this.  The code
> in question is "include/crm/crm.h", around line 225:
>    #define crm_err(fmt, args...)     do_crm_log(LOG_ERR,     fmt, ##args)
>
> (and similar lines) which now expand incorrectly, leaving a trailing ","
> in that old version of gcc.

iirc, this could be fixed by an extra space...
#define crm_err(fmt, args...)     do_crm_log(LOG_ERR, fmt , ##args)
                                                         ^^^
so the comma is not the last "token" but the last "word" before the ##
i may be wrong, though...

-- 
: Lars Ellenberg                            Tel +43-1-8178292-55 :
: LINBIT Information Technologies GmbH      Fax +43-1-8178292-82 :
: Vivenotgasse 48, A-1120 Vienna/Europe    http://www.linbit.com :