[Linux-ha-dev] [PATCH]The change of the required parameter of FileSystem resources for GUI.

[HIDEO YAMAUCHI]

Hi,

When operator set Filesystem in GUI, there is the case that a operator forgets setting of directory.

In addition, that the setting of directory is required is described in a Filesystem resource.

-----------------------OCF FileSystem -------------------------------------------
# It is possible that OCF_RESKEY_directory has one or even multiple trailing "/".
# But the output of `mount` and /proc/mounts do not.
if [ -z "$OCF_RESKEY_directory" ]; then
    if [ X$OP = "Xstart" -o $blockdevice = "no" ]; then
        ocf_log err "Please specify the directory"
        exit $OCF_ERR_ARGS
    fi
else
----------------------------------------------------------------------------------

I request that a directory parameter becomes the required item to prevent the mistake of the operator.

----------------------FileSystem.patch--------------------------------------------
diff -r 2115cf46e7e2 resources/OCF/Filesystem
--- a/resources/OCF/Filesystem	Mon Dec 03 16:56:05 2007 +0100
+++ b/resources/OCF/Filesystem	Tue Dec 11 14:37:04 2007 +0900
@@ -102,7 +102,7 @@ The name of block device for the filesys
 <content type="string" default="" />
 </parameter>
 
-<parameter name="directory" unique="1">
+<parameter name="directory" required="1" unique="1">
 <longdesc lang="en">
 The mount point for the filesystem.
 </longdesc>
----------------------------------------------------------------------------------

Regards,
Hideo Yamauchi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FileSystem.patch
Type: application/octet-stream
Size: 452 bytes
Desc: pat562915370
Url : http://lists.community.tummy.com/pipermail/linux-ha-dev/attachments/20071211/449d284c/FileSystem.obj