pgsql ra (WAS: Re: [Linux-ha-dev] ids ra)

[Serge Dubrouski]

Both operations include calling pg_ctl or psql. validate_all checks
that they are set in the right way.

On Dec 10, 2007 12:13 PM, Dejan Muhamedagic <dejanmm at fastmail.fm> wrote:
> Hi,
>
> On Mon, Dec 10, 2007 at 08:58:03AM -0700, Serge Dubrouski wrote:
> > That is not true. validate_all isn't called for "methods" and "meta-data"
>
> It shouldn't be called for stop and monitor either. Both
> operations should behave as if the resource is in a stopped
> state.
>
> Thanks,
>
> Dejan
>
>
> > On Dec 10, 2007 8:10 AM, Dominik Klein <dk at in-telegence.net> wrote:
> > > > OCF resource agents should be able to run meta-data, monitor, and
> > > > stop even when there is no required software installed:
> > > >
> > > > - meta-data should run ok
> > > > - monitor should return 7 (resource stopped)
> > > > - stop should return 0 (success)
> > > >
> > > > Can you please fix that?
> > >
> > > I think this also needs fixing in the pgsql RA. Because *every* time it
> > > is run, it calls:
> > >
> > > pgsql_validate_all() {
> > >
> > >      check_binary $SH
> > >      check_binary $OCF_RESKEY_pgctl
> > >      check_binary $OCF_RESKEY_psql
> > >
> > >      return $OCF_SUCCESS
> > > }
> > >
> > > if ! pgsql_validate_all
> > > then
> > >      exit $OCF_ERR_CONFIGURED
> > > fi
> > >
> > > This is a problem
> > >
> > > a) if Postgres is not installed
> > > b) if Postgres is installed on a shared disc, which is not mounted yet
> > > (e.g. in a group configuration)
> > >
> > > Regards
> > > Dominik
> > > _______________________________________________________
> > > Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > Home Page: http://linux-ha.org/
> > >
> >
> >
> >
> > --
> > Serge Dubrouski.
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>



-- 
Serge Dubrouski.