[Linux-ha-dev] Re: pgsql and quotes

Serge Dubrouski sergeyfd at gmail.com
Mon Dec 10 09:07:26 MST 2007


It will not. Why do you want to make this change?

I'll create a patch for moving that check for root down the code today.

On Dec 10, 2007 7:26 AM, Dejan Muhamedagic <dejanmm at fastmail.fm> wrote:
> Hi Serge,
>
> Is this thing going to work:
>
> 197     if runasowner "$OCF_RESKEY_pgctl $OCF_RESKEY_ctl_opt -D $OCF_RESKEY_pgdata -l $OCF_RESKEY_logfile -o "\'$OCF_RESKEY_start_opt\'" start > /dev/null 2 >&1"
>
> Should it be:
>
> 197     if runasowner "$OCF_RESKEY_pgctl $OCF_RESKEY_ctl_opt -D $OCF_RESKEY_pgdata -l $OCF_RESKEY_logfile -o \"\'$OCF_RESKEY_start_opt\'\" start > /dev/null 2 >&1"
>
> Also, the test for root is too early, i.e. at least one should be
> able to run meta-data as any user.
>
> Thanks,
>
> Dejan
>



-- 
Serge Dubrouski.


More information about the Linux-HA-Dev mailing list