[Linux-ha-dev] Re: [mgmt][patch8]Target_role issue for sub-resource

[Lars Marowsky-Bree]

On 2007-08-29T17:11:44, Yan Gao <ygao at novell.com> wrote:

> mgmt patch 8:
> http://coolpix.a-s-k.hk/~gaoyan/heartbeat-0809-target_role.patch
> 
> Signed-off-by: Yan Gao <ygao at novell.com>
> 
> Description:
> Resolve target_role problem for sub-resource.
> 
> *Remove the default target_role parameter added in the dialog of adding
> resources. If adding a native resource, a target_role with value of
> "stopped" will be just set.
> 
> *If adding a resource belonging to a new-group/clone/master_slave, a
> target_role with value of "stopped" will be set for the parent,and
> nothing will be set for the child.If a user sets target_role himself,
> haclient will prompt a dialog for user confirmation.

Does this work if the new-group also gets other instance attributes set?

Besides, when you're changing this code, you could, preferably, set
the target_role as a meta_attribute instead ;-)

> *When start/stop a group/clone/ms, haclient will check the target_roles
> of all sub-resources recursively, dialogs are prompted for user to
> retain them or clean them up when found.
> 
> *Rewrite the "confirmbox" to make dialogs less ugly;-)
> 
> bug#1619:
> http://old.linux-foundation.org/developer_bugzilla/show_bug.cgi?id=1619
> bug#1388
> http://old.linux-foundation.org/developer_bugzilla/show_bug.cgi?id=1388
> 
> Reference:
> http://old.linux-foundation.org/developer_bugzilla/show_bug.cgi?id=1449
> https://bugzilla.novell.com/show_bug.cgi?id=291749

OK otherwise, thanks!