[Linux-ha-dev] More commit comments
zhenhltc at cn.ibm.com
Mon Oct 2 07:03:14 MDT 2006
Andrew Beekhof wrote:
> The name of this file is just awful:
> What does 2_0_8 refer to? Are we planning to have each version use a
> different implementation/algorithm?
2_0_8 is the protocol version. Different versons of heartbeat may share one same protocol.
When we add a new implementation, we just need put a new plugin with the new version.
And when the client connects it will send the version of protocol.
quorumd will call different plugin according to the version of protocol.
So we don't need stop the quorumd to deploy new version of protocols.
> I'd like to understand the commit message:
> "with quorumd, membership unchanged but quorum may changed"
> can you give an example?
For example, one cluster has been splited to two partitions, A and B.
A had 3 nodes and B had 2 nodes. Both A and B connected to the quorumd.
quorumd judged that A had the quorum.
Later, two new nodes added to partation B, then B had 4 nodes.
So quorumd changed the judgement and gave B the quorum.
In this case, for partition A, no node added or left, but its quorum lost.
> Just so you know for next time... "Merge with XYZ" is the generally
> terminology for these types of commits.
> in addition to the previous email - the commit message could have been
> clearer as to why this was done.
Ok, I will pay more attention on the comment.
> Andrew Beekhof
> "Would the last person to leave please turn out the enlightenment?" - TISM
> Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> Home Page: http://linux-ha.org/
Linux-HA, Linux Technology Center, China Systems & Technology Lab
China Development Labs, Beijing Tel: 86-10-82782244 Ext. 2845
Email: zhenhltc at cn.ibm.com
More information about the Linux-HA-Dev