[Linux-ha-dev] LRM "Fix Me" needs to be fixed

[Andrew Beekhof]

On 10/20/06, Huang Zhen <zhenhltc at cn.ibm.com> wrote:
> Hi,
>
> get_all_type_metadata() is to return metadata of all types of all RAs.
         ^^^
> Till now, there is no requirement to return all these metadata in one call.
                                                               ^^^

it would seem to be implied :-)

Actually that function wont return _any_ metadata because no provider
is supplied in the calls it makes.

> So none of other parts calls this function.
> Do you think we can remove this function?

shrug.
i was going to use that function but i've decided against using the
metadata at all  for this.

either it should work or it should go away.
no longer needing it myself i'll leave that decision up to you :-)

> Usually, we use following function to get the metadata for a certain RA.
> char* (*get_rsc_type_metadata)(ll_lrm_t*, const char* rsc_class,
>         const char* rsc_type, const char* rsc_provider);
>
>
> Andrew Beekhof wrote:
> > This looks kind of important - especially if the crm is going to  reload
> > or restart based on the metadata.
> >
> > Surely this should affect the GUI too.  I wonder why no-one noticed?
> >
> > /*
> > * lrm_get_all_type_metadatas():
> > * For OCF RAs, they may have more than one providers so they may have
> > more than
> > * one metadata. The hash table is not suitable for this. Fix Me
> > */
> > static GHashTable*
> > lrm_get_all_type_metadata (ll_lrm_t* lrm, const char* rclass)
> >
> >
> > --
> > Andrew Beekhof
> >
> > "Would the last person to leave please turn out the enlightenment?" -  TISM
> >
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
>
>
> --
> Best Regards,
> Huang Zhen
> Linux-HA, Linux Technology Center, China Systems & Technology Lab
> China Development Labs, Beijing Tel: 86-10-82782244 Ext. 2845
> Email: zhenhltc at cn.ibm.com
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>