[Linux-ha-dev] Re: [Linux-ha-cvs] Linux-HA CVS: resources by
xun.sun.cn at gmail.com
Sun Nov 13 10:14:12 MST 2005
On 11/13/05, David Lee <t.d.lee at durham.ac.uk> wrote:
> On Sat, 12 Nov 2005, Xun Sun wrote:
> > On 11/12/05, David Lee <t.d.lee at durham.ac.uk> wrote:
> >> On Sat, 12 Nov 2005, Xun Sun wrote:
> >>> Hi David,
> >>> In this commit you defined ocf_is_hexadecimal in ocf-shellfuncs.in,
> >>> but used ocf_is_hex in other places, which looks inconsistent to me.
> >>> Unfortunately you seem unaware of this problem even though I mentioned
> >>> it in my last two mails ;-)
> >>> So I have just committed a one-liner fix for this. Feel free to change
> >>> to other appropriate things.
> >> Yes. My mistake entirely, for which my apologies. Thanks for fixing it.
> >> I also saw your other point about my re-implementing the pattern matching
> >> (rewriting the "case" statement into a "tr"). I'm still looking at that.
> >> The original "case" was failing on my Solaris "sh", hence my looking for
> > How did it fail, syntax error or giving wrong output (in this case it
> > is possible that my original script is faulty) ? Could you please send
> > me a transcript if possible?
> It turned out to be a very simple thing. The "case" syntax "[^...]" (i.e.
> the "^" for negation) is non-portable. But changing this to "[!...]"
> (i.e. the "!") seems both functionally equivalent and portable.
> Proposed patch attached.
Looks fine to me, however could you please check the parameters passed
to them are never empty string? I remeber having wrote "We know $1 is
not empty beforehand" in some places, where we need not worry about
However please check if you have changed other places, if you have
time. I have to rush into the work to submit to my teacher tomorrow...
> : David Lee I.T. Service :
> : Senior Systems Programmer Computer Centre :
> : Durham University :
> : http://www.dur.ac.uk/t.d.lee/ South Road :
> : Durham DH1 3LE :
> : Phone: +44 191 334 2752 U.K. :
> Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> Home Page: http://linux-ha.org/
Thanks & regards
More information about the Linux-HA-Dev