[Linux-ha-dev] 1.2.3 stable on the way...

[Soffen, Matthew]

Alan, Can you try to use the --enable-ansi flag and see if all builds well
on Linux now that I have fixed most of them ( I haven't built it since
Saturday otherwise I think I would have seen this one)? 

Matt



-----Original Message-----
From: David Lee [mailto:t.d.lee at durham.ac.uk]
Sent: Monday, September 13, 2004 11:17 AM
To: High-Availability Linux Development List
Subject: Re: [Linux-ha-dev] 1.2.3 stable on the way...


On Sat, 11 Sep 2004, Alan Robertson wrote:

> [...]
> Due to an error on my part, I redid your patch to Makefile.am, and put
> everything in.  I've attached the patch describing the changes I actually
> put in.  They're in 1.2.x now.
>
> Let me know if I botched it, and I'll fix it.  I'll be merging a few other
> minor bug fixes for a problem found by a verification tool.  But, they
> shouldn't affect Solaris.

Many thanks.  That patch (and the patch to the patch) looks OK (indeed, I
think you've improved one aspect of it!).

But I'm now getting a new build error which is completely independent of
that:

===================== snip ================
gcc -DHAVE_CONFIG_H -I. -I../../heartbeat -I../linux-ha -I../include
-I../include -I../../include -I../linux-ha -I../../linux-ha -I../libltdl
-I../../libltdl  -I/usr/local/include -I/opt/sfw/include
-I/usr/local/include/glib-1.2 -I/usr/local/lib/glib/include
-I/usr/include/libxml2/libxml -I/usr/include/libxml2 -g -O2
-fno-strict-aliasing  -Wall -Wmissing-prototypes -Wmissing-declarations
-Wstrict-prototypes -Wpointer-arith -Wwrite-strings -Wcast-qual -Wcast-align
-Wbad-function-cast -Winline -Wformat=2 -Wformat-security
-Wformat-nonliteral -Wno-long-long   -ggdb3 -DVAR_RUN_D='"/opt/var/run"'
-DVAR_LIB_D='"/opt/var/lib/heartbeat"' -DHA_D='"/opt/etc/ha.d"'
-DHALIB='"/opt/lib/heartbeat"' -g -O2 -fno-strict-aliasing  -Wall
-Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes
-Wpointer-arith -Wwrite-strings -Wcast-qual -Wcast-align -Wbad-function-cast
-Winline -Wformat=2 -Wformat-security -Wformat-nonliteral -Wno-long-long
-ggdb3 -c ../../heartbeat/cl_status.c
../../heartbeat/cl_status.c: In function `hbparameter':
../../heartbeat/cl_status.c:700: parse error before `char'
../../heartbeat/cl_status.c:701: `pvalue' undeclared (first use in this
function)
../../heartbeat/cl_status.c:701: (Each undeclared identifier is reported
only once
../../heartbeat/cl_status.c:701: for each function it appears in.)
gmake[2]: *** [cl_status.o] Error 1
===================== snip ================

The recent 1.1.2.8->1.1.2.9 change in heartbeat/cl_status.c seems to have
introduced one of those pesky "declaration in the middle of a block"
errors that break traditional forms of C.

Patch:
======================= snip =============
--- heartbeat/cl_status.c.orig  2004-09-13 14:58:15.000000000 +0100
+++ heartbeat/cl_status.c       2004-09-13 16:12:35.539390000 +0100
@@ -696,8 +696,8 @@
        } while (1);

        if ( paramname != NULL ) {
-               cl_log(LOG_INFO,"paramname: %s", paramname);
                char * pvalue;
+               cl_log(LOG_INFO,"paramname: %s", paramname);
                pvalue = hb->llc_ops->get_parameter(hb, paramname);
                if (pvalue == NULL) {
                        cl_log(LOG_ERR, "Cannot get parameter %s's value",
======================= snip =============


-- 

:  David Lee                                I.T. Service          :
:  Systems Programmer                       Computer Centre       :
:                                           University of Durham  :
:  http://www.dur.ac.uk/t.d.lee/            South Road            :
:                                           Durham                :
:  Phone: +44 191 334 2752                  U.K.                  :
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/