[Linux-ha-dev] Re: Linux-HA CVS: lib by sunjd from
alanr at unix.sh
Fri Sep 10 10:41:19 MDT 2004
Lars Marowsky-Bree wrote:
> On 2004-09-10T10:22:23,
> linux-ha-cvs at lists.community.tummy.com said:
> Hi sunjd, thanks for cleaning the code up! Just some more suggestions.
> But the suggestions are growing less and less severe, so that's good!
>> /* Rource agent execution plugin operations */
>>@@ -165,21 +166,22 @@
>> } while (params_argv[++index_tmp] != NULL);
>> debug_info->str[debug_info->len-1] = '\0';
>> cl_log(LOG_DEBUG, "Will execute a heartbeat RA: %s", debug_info->str);
>>+ cl_log(LOG_ERR, "Will execute a heartbeat RA: %s", debug_info->str);
I have a little more stringent comment about the use of LOG_ERR. I need to
document this in the coding standards. So, it's not really your fault you
If an ERROR: message comes out during testing - the test fails.
Use ERROR: ONLY when you want testing to fail if it comes out. But, any
time something REALLY bad happens ALWAYS use ERROR messages - because that
means we WANT testing to fail if this comes out.
Alan Robertson <alanr at unix.sh>
"Openness is the foundation and preservative of friendship... Let me claim
from you at all times your undisguised opinions." - William Wilberforce
More information about the Linux-HA-Dev