[Linux-ha-dev] Re: [Linux-ha-cvs] Linux-HA CVS: linux-ha by gshi from
lists at beekhof.homeip.net
Tue Jun 22 03:20:59 MDT 2004
On Jun 22, 2004, at 11:04 AM, Horms wrote:
> On Mon, Jun 21, 2004 at 10:53:19AM +0200, Andrew wrote:
>> On Jun 21, 2004, at 3:43 AM, Horms wrote:
>>>>> I am not sure that I agree with the approach.
>>>>> Yes, the module should not be built if the library is not there.
>>>>> But it should still get included in a make dist. I don't
>>>>> believe this allows for that.
>>>> I'm not sure what's wrong. Can you fix it?
>>> Sure. What I would propose is always including the Makefile.am and
>>> its directory in the build. And having the Makefile.am to only
>>> build the code if it is needed. There might be other optional
>>> pieces of code in the tree that are in the same boat.
>> The CRM could probably do with that treatment.
>>> Would you like me to look into this and produce a patch / CVS commit
> I have gone over the whole tree and made it so
> all, and I mean all source files should now be included in the
> distrubted tar ball. Curiously I discovered some code,
> the snmp_subagent (snmp_subagent/), and perl bindings (lib/bindings/)
> that would never be incuded in the tar ball, no matter what.
> Also, lmb, I had to do some surgery to lib/bindings/Makefile.am
> to inculde a bunch of extra files in the tar ball and make it
> build under makedistcheck. You might want to doble check what
> I have done there.
No problems here. Nice work.
> Patch is attached for refereance.
> Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> Home Page: http://linux-ha.org/
More information about the Linux-HA-Dev