[Linux-ha-dev] Re: [Linux-ha-cvs] Linux-HA CVS: lib by yixiong from

[Lars Marowsky-Bree]

On 2004-11-30T17:35:01, linux-ha-cvs at lists.linux-ha.org wrote:

> linux-ha CVS committal
> 
> Author  : yixiong
> Host    : 
> Project : linux-ha
> Module  : lib
> 
> Dir     : linux-ha/lib/plugins/stonith
> 
> 
> Modified Files:
>       Tag: STABLE_1_2
> 	ipmilan.c ipmilan.h ipmilan_command.c ipmilan_test.c 
> 
> 
> Log Message:
> sync up the ipmi_lan stonith plugin with the main trunk.

Hi yixiong, I'm just checking back whether you are aware that 1.2.x is
supposed to be a _stable_ release, which ought to consist of bugfixes
and "safe" feature updates/additions only. 

You're backporting quite big changes to it from HEAD w/o at least a
short mail to the list of why, or even better, maybe we ought to require
bugzilla entries for changes to go into stable releases. (I think that
would be a good policy.)

Which, however:

> -PIL_PLUGIN_BOILERPLATE("1.0", Debug, ipmilanclosepi);
> -static const PILPluginImports*  PluginImports;
> +PIL_PLUGIN_BOILERPLATE2("1.0", Debug);

... won't even compile, because _BOILERPLATE2 is a short-hand macro
which is new in HEAD and doesn't exist in the STABLE_1_2 branch.

Could I please ask you to be a bit more careful here? You're help and
work is greatly appreciated, but we need to make sure that 1.2.x stays
stable; new development really ought to go to the HEAD branch, which
will in turn accelerate the release of 2.0 and make backports to 1.2
less necessary.

Thanks for your consideration!


Sincerely,
    Lars Marowsky-Brée <lmb at suse.de>

-- 
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business