[Linux-ha-announce] NOTICE: ping broken in 2.0.1 - please try ping_group instead

[Alan Robertson]

Hi,

It looks like a key statement was accidentally deleted from the ping 
code in 2.0.1, and it doesn't look like the corresponding error was made 
in ping_group.

Please try ping_group instead, and let the list know if it's working for 
you.  It looks like the corresponding error was _not_ made in ping_group.

We'll put out a new release as soon as we can test it.

The delta in error is this one:
http://cvs.linux-ha.org/viewcvs/viewcvs.cgi/linux-ha/lib/plugins/HBcomm/ping.c?r1=1.43&r2=1.44

The observant will note that this memcpy statement was deleted:
   memcpy(pkt, buf.cbuf + hlen + ICMP_HDR_SZ, pktlen);

This statement actually makes the data available to be passed along to 
heartbeat.  By deleting it, the ping data is undefined (garbage).

Sorry for the bug.  We'll put out a new release as soon as we can test it.


-- 
     Alan Robertson <alanr at unix.sh>

"Openness is the foundation and preservative of friendship...  Let me 
claim from you at all times your undisguised opinions." - William 
Wilberforce