[ENBD] (no subject)

[Peter T. Breuer]

"A month of sundays ago HUDZIA Bertrand wrote:"
> On Wed, 10 Apr 2002 20:16:18 +0200 (MET DST)

> 	[a] Despatched: 24.647M (24.6M) 16.12MR/8.520MW md5 8.52MW (8.52M eq, 0
> ne, 0 dn)	[a] Errored:    0       (0)     0+0

This bit has me worried. You see, my driver code has a "\n" between the lines
for Despatched and Errored! It occurs between labels 10 and 11 in
the proc/ code:


           NBD_PROC_LABEL (10);

        do {                    // PTB begin short do once block
            int j;
            char buff[2][8];
            for (j = 0; j < lo->nslot; j++) {
                struct nbd_slot *slotj = &lo->slots[j];
                len += sprintf (buf + len, "\t(%s)", display (slotj->out, 5));
            }
            strncpy (buff[0],
                     display (atomic_read (&lo->requests_out[READ]), 6), 7);
            strncpy (buff[1],
                     display (atomic_read (&lo->requests_out[WRITE]), 6), 7);
            len += sprintf (buf + len, "\t%sR/%sW", buff[0], buff[1]);
            len += sprintf (buf + len, "\tmd5 %sW",
                            display (atomic_read (&lo->wrequests_5to), 5));
            len += sprintf (buf + len, " (%s eq,",
                            display (atomic_read (&lo->wrequests_5so), 5));
            len += sprintf (buf + len, " %s ne,",
                            display (atomic_read (&lo->wrequests_5wo), 5));
            len += sprintf (buf + len, " %s dn)",
                            display (atomic_read (&lo->wrequests_5eo), 5));
        } while (0);            // PTB end short do once block

        len += sprintf (buf + len, "\n");
                       ^^^^^^^^^^^^^^^^^^^^^^^^^ !! The missing \n
        len += sprintf (buf + len, "[%s] Errored:\t%s", devnam,
                        display (atomic_read (&lo->requests_err), 7));

        NBD_PROC_LABEL (11);


Tnat and your missing "Spectrum" leads me to suspect that the code  is
miscompiled in some way.


> 	[a] Pending:    4       (4)     0R/4W+0R/132W
> 	[a] B/s now:    540K    (11.0KR+527KW)
> 	[a] B/s ave:    3.98G   (13.1MR+6.96MW)
> 	[a] B/s max:    4.99M   (3.19GR+1.61GW)
> 	[a] Spectrum:
> 	[a] Kthreads:   0       (0 waiting/0 running/1 max)
> 	[a] Cthreads:   0       (-)
> 	[a] Cpids:      0       (8272)
> 	Device b-p:     Closed

Peter