[ENBD] 2.4.23 released

[Leonid Andreev]

On Wed, 28 Mar 2001, Peter T. Breuer wrote:

  ...
>
>    ftp://oboe.it.uc3m.es/pub/Programs/nbd-2.4.23.tgz
>

Hi,

it doesn't seem to compile for kernel 2.2.* (2.2.17 in my case); is it supposed to?

gcc -O2 -Wall -D_LARGEFILE64_SOURCE -D__KERNEL__ -DMODULE -DDEBUG=0 -I/usr/local/src/ENBD/nbd-2.4.23/linux/include -I/usr/src/linux/include -DUNIX98_NR_MAJORS=UNIX98_PTY_MAJOR_COUNT  -c -o nbd.o /usr/local/src/ENBD/nbd-2.4.23/linux/drivers/block/nbd.c
d.c:161:
/usr/local/src/ENBD/nbd-2.4.23/linux/drivers/block/nbd.c: In function `init_module':
/usr/local/src/ENBD/nbd-2.4.23/linux/drivers/block/nbd.c:3725: `ll_plug_device_fn' undeclared (first use in this function)
/usr/local/src/ENBD/nbd-2.4.23/linux/drivers/block/nbd.c:3725: (Each undeclared identifier is reported only once
/usr/local/src/ENBD/nbd-2.4.23/linux/drivers/block/nbd.c:3725: for each function it appears in.)
/usr/local/src/ENBD/nbd-2.4.23/linux/drivers/block/nbd.c:3725: structure has no member named `plug_device_fn'

It looks like

static plug_device_fn *ll_plug_device_fn;

is defined only #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,3,30)

and the following:

    ll_plug_device_fn = (BLK_DEFAULT_QUEUE(major))->plug_device_fn;
    blk_queue_pluggable(BLK_DEFAULT_QUEUE(major), nbd_plug_device_fn);

is always there in nbd_init().

Should I just add the same #if ... #endif around these 2 lines?

thanks a lot!

I haven't been following ENBD developments for a while. But I can
report that the version 2.4.14 that I built back in October has been
running flawlessly for almost 5 months, serving a partition in a raid1
setup on my production mail server. You get my sincere praise for this
amazing piece of code.

-L.