[ENBD] Re: the files of ENBD

[Peter T. Breuer]

"A month of sundays ago Wang Gang wrote:"
>I have modified nbd-server.c and nbd-client.c. I found you have add new timeout
>functions into nbd.c and nbd.h. Because show_err option is per node, I think
>adding a ioctl command to let user set it is not good and necessary.  Perhaps
>it should be per device? I put the patch of nbd-server.c and nbd-client.c in
>the attachment.

Hi, yes, many thanks for the patch. I have applied it to the current 2.2.29
source (it's sooooo much easier when someone else does the hard work!).
I have confirmed it compiles and runs - at least passing basic read and
write regression tests.

New timeout functions in the driver? I don't follow. Do you mean the
SET_INTVL ioctl to set the timeout that determines how a request is
"aged"? I thought that was yours! Or do you mean in the daemons?

It seems to me that show_errs=1 should be per nbd device (per node),
because it depends on the mode of use of that device as to which
behaviour you want from it.  Thus each client daemon needs to set it or
not as it cares to for its own device.  At the moment you can only set
it for all devices, or no devices, in the module itself. So I think one
does need the extra ioctl.

I'm updating documentation now.

Peter